xkb: Fix key type map entry field order
authorRan Benita <ran234@gmail.com>
Sun, 4 Aug 2013 10:33:30 +0000 (13:33 +0300)
committerDaniel Martin <consume.noise@gmail.com>
Wed, 14 Aug 2013 22:23:46 +0000 (00:23 +0200)
In fact, unlike the deleted comment says, both Xlib and the server use
the order as specified in the protocol spec:
http://www.x.org/releases/current/doc/kbproto/xkbproto.html#appD::Requests
(Search for KB_KTMAPENTRY).

Also see struct xkbKTMapEntryWireDesc in
/usr/include/X11/extensions/XKBproto.h

Reviewed-by: Peter Harris <pharris@opentext.com>
Reviewed-by: Daniel Martin <consume.noise@gmail.com>
Signed-off-by: Ran Benita <ran234@gmail.com>
src/xkb.xml

index 15b3368..6de634e 100644 (file)
@@ -410,12 +410,8 @@ authorization from the authors.
 
        <struct name="KTMapEntry">
                <field name="active" type="BOOL" />
-               <!-- Xlib uses a different arrangement of fields
                <field name="mods_mask" type="CARD8" mask="ModMask" />
                <field name="level" type="CARD8" />
-               -->
-               <field name="level" type="CARD8" />
-               <field name="mods_mask" type="CARD8" mask="ModMask" />
                <field name="mods_mods" type="CARD8" mask="ModMask" />
                <field name="mods_vmods" type="CARD16" mask="VMod" />
                <pad bytes="2" />