dri2: Add notes on lists that should be linked to their length fields but are not.
authorRobert Ancell <robert.ancell@canonical.com>
Fri, 30 May 2014 07:37:14 +0000 (09:37 +0200)
committerPeter Harris <pharris@opentext.com>
Tue, 10 Jun 2014 17:53:16 +0000 (13:53 -0400)
Reviewed-by: Daniel Martin <consume.noise@gmail.com>
src/dri2.xml

index 20d6649..3b4c12e 100644 (file)
@@ -133,7 +133,10 @@ authorization from the authors.
   <request name="GetBuffers" opcode="5">
     <field type="DRAWABLE" name="drawable" />
     <field type="CARD32" name="count" />
-    <list type="CARD32" name="attachments" />
+    <list type="CARD32" name="attachments">
+    <!-- The length field should be linked but we can't correct it without breaking API -->
+    <!-- <fieldref>count</fieldref> -->
+    </list>
     <reply>
       <pad bytes="1" />
       <field type="CARD32" name="width" />
@@ -159,7 +162,10 @@ authorization from the authors.
   <request name="GetBuffersWithFormat" opcode="7">
     <field type="DRAWABLE" name="drawable" />
     <field type="CARD32" name="count" />
-    <list type="AttachFormat" name="attachments" />
+    <list type="AttachFormat" name="attachments">
+    <!-- The length field should be linked but we can't correct it without breaking API -->
+    <!-- <fieldref>count</fieldref> -->
+    </list>
     <reply>
       <pad bytes="1" />
       <field type="CARD32" name="width" />