config: default option for enable-dri3 is not implemented
authorGaetan Nadon <memsize@videotron.ca>
Wed, 26 Mar 2014 19:24:44 +0000 (15:24 -0400)
committerUli Schlachter <psychon@znc.in>
Wed, 6 Aug 2014 11:26:08 +0000 (13:26 +0200)
commit7f07b57be587a2ebe0cadceba3fe67ed4a1e79db
tree8dde40a9a351131223e0ef28b94a3795772f207a
parentd1e8ec96fca4862f37ec9f0e9407bb989c4c161a
config: default option for enable-dri3 is not implemented

The first symptom is the help text:

  --enable-dri3     Build XCB DRI3 Extension (default: "$sendfds")

The implementation variable $sendfds leaked into the user interface.
Testing the various user inputs:
  <nothing>                DRI3 is enabled     PASS
  --enable-dri3    DRI3 is enabled     PASS
  --enable-dri3=yes        DRI3 is enabled     PASS
  --enable-dri3=no         DRI3 is disabled    PASS
  --disable-dri3           DRI3 is disabled    PASS
  --enable-dri3=$sendfds   DRI3 is disabled    FAIL

This patch implements the usual idiom for features that are enabled by
default if the various conditions are met (sendfds is available).
New help text:

  --enable-dri3     Build XCB DRI3 Extension (default: auto)

With the additional user input:

  --enable-dri3=auto

which is equivalent to providing no input at all.

Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Signed-off-by: Gaetan Nadon <memsize@videotron.ca>
Signed-off-by: Uli Schlachter <psychon@znc.in>
configure.ac
m4/xcb.m4