#include "xcbext.h"
#include "xcbint.h"
+struct event_list {
+ XCBGenericEvent *event;
+ struct event_list *next;
+};
+
typedef struct pending_reply {
unsigned int request;
enum workarounds workaround;
+ int flags;
struct pending_reply *next;
} pending_reply;
typedef struct XCBReplyData {
unsigned int request;
void *data;
- XCBGenericError **error;
} XCBReplyData;
-static int match_request_error(const void *request, const void *data)
-{
- const XCBGenericError *e = data;
- return e->response_type == 0 && e->sequence == ((*(unsigned int *) request) & 0xffff);
-}
-
static int match_reply(const void *request, const void *data)
{
return ((XCBReplyData *) data)->request == *(unsigned int *) request;
{
XCBGenericRep genrep;
int length = 32;
- unsigned char *buf;
+ void *buf;
+ pending_reply *pend = 0;
+ struct event_list *event;
/* Wait for there to be enough data for us to read a whole packet */
if(c->in.queue_len < length)
{
int lastread = c->in.request_read;
c->in.request_read = (lastread & 0xffff0000) | genrep.sequence;
- if(c->in.request_read != lastread && !_xcb_queue_is_empty(c->in.current_reply))
+ if(c->in.request_read != lastread)
{
- _xcb_map_put(c->in.replies, lastread, c->in.current_reply);
- c->in.current_reply = _xcb_queue_new();
+ pending_reply *oldpend = c->in.pending_replies;
+ if(oldpend && oldpend->request == lastread)
+ {
+ c->in.pending_replies = oldpend->next;
+ if(!oldpend->next)
+ c->in.pending_replies_tail = &c->in.pending_replies;
+ free(oldpend);
+ }
+ if(!_xcb_queue_is_empty(c->in.current_reply))
+ {
+ _xcb_map_put(c->in.replies, lastread, c->in.current_reply);
+ c->in.current_reply = _xcb_queue_new();
+ }
}
if(c->in.request_read < lastread)
c->in.request_read += 0x10000;
}
+ if(genrep.response_type == 0 || genrep.response_type == 1)
+ {
+ pend = c->in.pending_replies;
+ if(pend && pend->request != c->in.request_read)
+ pend = 0;
+ }
+
/* For reply packets, check that the entire packet is available. */
if(genrep.response_type == 1)
{
- pending_reply *pend = c->in.pending_replies;
- if(pend && pend->request == c->in.request_read)
+ if(pend && pend->workaround == WORKAROUND_GLX_GET_FB_CONFIGS_BUG)
{
- switch(pend->workaround)
- {
- case WORKAROUND_NONE:
- break;
- case WORKAROUND_GLX_GET_FB_CONFIGS_BUG:
- {
- CARD32 *p = (CARD32 *) c->in.queue;
- genrep.length = p[2] * p[3] * 2;
- }
- break;
- }
- c->in.pending_replies = pend->next;
- if(!pend->next)
- c->in.pending_replies_tail = &c->in.pending_replies;
- free(pend);
+ CARD32 *p = (CARD32 *) c->in.queue;
+ genrep.length = p[2] * p[3] * 2;
}
length += genrep.length * 4;
}
return 0;
}
- if(buf[0] == 1) /* response is a reply */
+ /* reply, or checked error */
+ if(genrep.response_type == 1 || (genrep.response_type == 0 && pend && (pend->flags & XCB_REQUEST_CHECKED)))
{
XCBReplyData *reader = _xcb_list_find(c->in.readers, match_reply, &c->in.request_read);
_xcb_queue_enqueue(c->in.current_reply, buf);
return 1;
}
- if(buf[0] == 0) /* response is an error */
+ /* event, or unchecked error */
+ event = malloc(sizeof(struct event_list));
+ if(!event)
{
- XCBReplyData *reader = _xcb_list_find(c->in.readers, match_reply, &c->in.request_read);
- if(reader && reader->error)
- {
- *reader->error = (XCBGenericError *) buf;
- pthread_cond_signal(reader->data);
- return 1;
- }
+ free(buf);
+ return 0;
}
-
- /* event, or error without a waiting reader */
- _xcb_queue_enqueue(c->in.events, buf);
+ event->event = buf;
+ event->next = 0;
+ *c->in.events_tail = event;
+ c->in.events_tail = &event->next;
pthread_cond_signal(&c->in.event_cond);
return 1; /* I have something for you... */
}
+static XCBGenericEvent *get_event(XCBConnection *c)
+{
+ struct event_list *cur = c->in.events;
+ XCBGenericEvent *ret;
+ if(!c->in.events)
+ return 0;
+ ret = cur->event;
+ c->in.events = cur->next;
+ if(!cur->next)
+ c->in.events_tail = &c->in.events;
+ free(cur);
+ return ret;
+}
+
static int read_block(const int fd, void *buf, const size_t len)
{
int done = 0;
if(_xcb_list_find(c->in.readers, match_reply, &request))
goto done; /* error */
- if(e)
- {
- *e = _xcb_list_remove(c->in.events, match_request_error, &request);
- if(*e)
- goto done;
- }
-
reader.request = request;
reader.data = &cond;
- reader.error = e;
_xcb_list_append(c->in.readers, &reader);
/* If this request has not been read yet, wait for it. */
- while(!(e && *e) && ((signed int) (c->in.request_read - request) < 0 ||
+ while(((signed int) (c->in.request_read - request) < 0 ||
(c->in.request_read == request &&
_xcb_queue_is_empty(c->in.current_reply))))
if(!_xcb_conn_wait(c, /*should_write*/ 0, &cond))
else
ret = _xcb_queue_dequeue(c->in.current_reply);
+ if(ret && ((XCBGenericRep *) ret)->response_type == 0) /* X error */
+ {
+ if(e)
+ *e = ret;
+ else
+ free(ret);
+ ret = 0;
+ }
+
done:
_xcb_list_remove(c->in.readers, match_reply, &request);
pthread_cond_destroy(&cond);
{
XCBGenericEvent *ret;
pthread_mutex_lock(&c->iolock);
- /* _xcb_list_remove_head returns 0 on empty list. */
- while(!(ret = _xcb_queue_dequeue(c->in.events)))
+ /* get_event returns 0 on empty list. */
+ while(!(ret = get_event(c)))
if(!_xcb_conn_wait(c, /*should_write*/ 0, &c->in.event_cond))
break;
*error = 0;
/* FIXME: follow X meets Z architecture changes. */
if(_xcb_in_read(c))
- ret = _xcb_queue_dequeue(c->in.events);
+ ret = get_event(c);
else if(error)
*error = -1;
else
in->current_reply = _xcb_queue_new();
in->replies = _xcb_map_new();
- in->events = _xcb_queue_new();
in->readers = _xcb_list_new();
- if(!in->current_reply || !in->replies || !in->events || !in->readers)
+ if(!in->current_reply || !in->replies || !in->readers)
return 0;
+ in->events_tail = &in->events;
in->pending_replies_tail = &in->pending_replies;
return 1;
pthread_cond_destroy(&in->event_cond);
_xcb_queue_delete(in->current_reply, free);
_xcb_map_delete(in->replies, free);
- _xcb_queue_delete(in->events, free);
_xcb_list_delete(in->readers, 0);
+ while(in->events)
+ {
+ struct event_list *e = in->events;
+ in->events = e->next;
+ free(e->event);
+ free(e);
+ }
while(in->pending_replies)
{
pending_reply *pend = in->pending_replies;
}
}
-int _xcb_in_expect_reply(XCBConnection *c, unsigned int request, enum workarounds workaround)
+int _xcb_in_expect_reply(XCBConnection *c, unsigned int request, enum workarounds workaround, int flags)
{
- if(workaround != WORKAROUND_NONE)
+ if(workaround != WORKAROUND_NONE || flags != 0)
{
pending_reply *pend = malloc(sizeof(pending_reply));
if(!pend)
return 0;
pend->request = request;
pend->workaround = workaround;
+ pend->flags = flags;
pend->next = 0;
*c->in.pending_replies_tail = pend;
c->in.pending_replies_tail = &pend->next;