From 11738b2af0d8bfcf5b2f7c0d3e6ade1a14866b94 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Diego=20=27Flameeyes=27=20Petten=C3=B2?= Date: Thu, 23 Nov 2006 15:15:30 +0100 Subject: [PATCH] Avoid race condition when using multiple make jobs Avoid race condition when symlinking XML files. When declaring a rule with many files as target, the rule is called when any of them is requested, resulting in multiple for loops happening during a make process using more than one job. Also, use '$(LN_S) -f' rather than removing and recreating a file, that one should be as supported as 'rm -f' and requires one less command. --- src/Makefile.am | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/Makefile.am b/src/Makefile.am index fdbd6b4..b02caf3 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -220,7 +220,4 @@ SUFFIXES = .xml -o $@ $(srcdir)/c-client.xsl $< $(EXTENSION_XML): - for i in $(EXTENSION_XML) ; do \ - rm -f $$i ; \ - $(LN_S) $(XCBPROTO_XCBINCLUDEDIR)/$$i $$i ; \ - done + $(LN_S) -f $(XCBPROTO_XCBINCLUDEDIR)/$@ $@ -- 2.34.1