From: Jamey Sharp <jamey@minilop.net>
Date: Sat, 9 Oct 2010 11:08:18 +0000 (-0700)
Subject: xcb_send_request: Send all requests using a common internal send_request.
X-Git-Url: http://git.demorecorder.com/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ee1bc1d28a1bda0526db90139edc1304d2ef3d7c;hp=ee1bc1d28a1bda0526db90139edc1304d2ef3d7c;p=free-sw%2Fxcb%2Flibxcb

xcb_send_request: Send all requests using a common internal send_request.

This simplifies the critical section of xcb_send_request and fixes a
couple of subtle bugs:

- It's possible for xcb_send_request to need to issue two sync requests
  before it can issue the real request. Previously, we counted sequence
  numbers as if both were issued, but only one went out on the wire.

- The test for whether to sync at 32-bit sequence number wrap has been
  incorrect since we switched to 64-bit sequence numbers internally.

This change means that if the output queue was already full and the
current request is bigger than the output queue, XCB will do one more
write syscall than it did before. But syncs are rare and small requests
are the norm, so this shouldn't be a measurable difference.

Signed-off-by: Jamey Sharp <jamey@minilop.net>
---