From: Christian Linhart <chris@demorecorder.com>
Date: Mon, 18 Aug 2014 14:41:21 +0000 (+0200)
Subject: xinput: rep SetDeviceMode.status: altenum to enum
X-Git-Url: http://git.demorecorder.com/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=3e6ddac96fb562c8675343d32fb25a2f6e3de17d;hp=36484e600c803b214a12f60c94fe81e4dc78980f;p=free-sw%2Fxcb%2Fproto

xinput: rep SetDeviceMode.status: altenum to enum

Field "status" of the SetDeviceMode-reply
only allows values from enum GrabStatus.

Therefore it has an "enum" and not an "altenum".

Also: Add comment about valid values of field "status".

spec:
http://cgit.freedesktop.org/xorg/proto/inputproto/tree/specs/XIproto.txt#n601

note:
The following spec also mentions value "3 + first_error":
http://cgit.freedesktop.org/xorg/lib/libXi/tree/specs/encoding.xml#n891

This is probably an error in this old spec because:
* the X-Server code does not generate that value.
  In case of error-codes, it does the following:
  instead of sending the reply it returns
  rep.status containing the error-code as returnvalue
  of the function ProcXSetDeviceMode.
  This will probably cause the sending of an XError.
  code:
    http://cgit.freedesktop.org/xorg/xserver/tree/Xi/setmode.c#n86

* the new spec does not mention that value:
  http://cgit.freedesktop.org/xorg/proto/inputproto/tree/specs/XIproto.txt#n601
---

diff --git a/src/xinput.xml b/src/xinput.xml
index 0c036bd..5b0070d 100644
--- a/src/xinput.xml
+++ b/src/xinput.xml
@@ -209,7 +209,8 @@ authorization from the authors.
         <pad bytes="2" />
         <reply>
             <pad bytes="1" />
-            <field type="CARD8" name="status" altenum="GrabStatus" />
+            <!-- values for status: 0: Success, 1: AlreadyGrabbed -->
+            <field type="CARD8" name="status" enum="GrabStatus" />
             <pad bytes="23" />
         </reply>
     </request>