From: Robert Ancell <robert.ancell@canonical.com>
Date: Fri, 30 May 2014 07:37:14 +0000 (+0200)
Subject: dri2: Add notes on lists that should be linked to their length fields but are not.
X-Git-Url: http://git.demorecorder.com/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=0797e4d51023cff3fe7f1d7acbd0b85efc379a31;p=free-sw%2Fxcb%2Fproto

dri2: Add notes on lists that should be linked to their length fields but are not.

Reviewed-by: Daniel Martin <consume.noise@gmail.com>
---

diff --git a/src/dri2.xml b/src/dri2.xml
index 20d6649..3b4c12e 100644
--- a/src/dri2.xml
+++ b/src/dri2.xml
@@ -133,7 +133,10 @@ authorization from the authors.
   <request name="GetBuffers" opcode="5">
     <field type="DRAWABLE" name="drawable" />
     <field type="CARD32" name="count" />
-    <list type="CARD32" name="attachments" />
+    <list type="CARD32" name="attachments">
+    <!-- The length field should be linked but we can't correct it without breaking API -->
+    <!-- <fieldref>count</fieldref> -->
+    </list>
     <reply>
       <pad bytes="1" />
       <field type="CARD32" name="width" />
@@ -159,7 +162,10 @@ authorization from the authors.
   <request name="GetBuffersWithFormat" opcode="7">
     <field type="DRAWABLE" name="drawable" />
     <field type="CARD32" name="count" />
-    <list type="AttachFormat" name="attachments" />
+    <list type="AttachFormat" name="attachments">
+    <!-- The length field should be linked but we can't correct it without breaking API -->
+    <!-- <fieldref>count</fieldref> -->
+    </list>
     <reply>
       <pad bytes="1" />
       <field type="CARD32" name="width" />