X-Git-Url: http://git.demorecorder.com/cgi-bin/gitweb.cgi?a=blobdiff_plain;f=src%2Fxcb_out.c;h=000b1211bd12f131552b9adfd8ee49085ff8d521;hb=1bbdba52116f127bed3ce812a00240b4009bbf22;hp=8eb8a7a6d2b0ea0bc9133357c7aaa37db206d36a;hpb=ff7b6c9124e7caf26381cc7a10fba9eaf1875652;p=free-sw%2Fxcb%2Flibxcb

diff --git a/src/xcb_out.c b/src/xcb_out.c
index 8eb8a7a..000b121 100644
--- a/src/xcb_out.c
+++ b/src/xcb_out.c
@@ -29,166 +29,220 @@
 #include <stdlib.h>
 #include <unistd.h>
 #include <string.h>
-#include <errno.h>
-
-#ifndef __GNUC__
-# if HAVE_ALLOCA_H
-#  include <alloca.h>
-# else
-#  ifdef _AIX
- #pragma alloca
-#  endif
-# endif
-#endif
 
 #include "xcb.h"
 #include "xcbext.h"
 #include "xcbint.h"
-#include "extensions/bigreq.h"
+#include "bigreq.h"
 
-static int force_sequence_wrap(XCBConnection *c)
+static int write_block(xcb_connection_t *c, struct iovec *vector, int count)
 {
-    int ret = 1;
-    if((c->out.request - c->in.request_read) > 65530)
+    while(count && c->out.queue_len + vector[0].iov_len <= sizeof(c->out.queue))
     {
-        pthread_mutex_unlock(&c->iolock);
-        ret = XCBSync(c, 0);
-        pthread_mutex_lock(&c->iolock);
+        memcpy(c->out.queue + c->out.queue_len, vector[0].iov_base, vector[0].iov_len);
+        c->out.queue_len += vector[0].iov_len;
+        vector[0].iov_base = (char *) vector[0].iov_base + vector[0].iov_len;
+        vector[0].iov_len = 0;
+        ++vector, --count;
     }
-    return ret;
+    if(!count)
+        return 1;
+
+    --vector, ++count;
+    vector[0].iov_base = c->out.queue;
+    vector[0].iov_len = c->out.queue_len;
+    c->out.queue_len = 0;
+    return _xcb_out_send(c, &vector, &count);
 }
 
 /* Public interface */
 
-CARD32 XCBGetMaximumRequestLength(XCBConnection *c)
+void xcb_prefetch_maximum_request_length(xcb_connection_t *c)
 {
+    if(c->has_error)
+        return;
     pthread_mutex_lock(&c->out.reqlenlock);
-    if(!c->out.maximum_request_length)
+    if(c->out.maximum_request_length_tag == LAZY_NONE)
     {
-        const XCBQueryExtensionRep *ext;
-        c->out.maximum_request_length = c->setup->maximum_request_length;
-        ext = XCBGetExtensionData(c, &XCBBigRequestsId);
+        const xcb_query_extension_reply_t *ext;
+        ext = xcb_get_extension_data(c, &xcb_big_requests_id);
         if(ext && ext->present)
         {
-            XCBBigRequestsEnableRep *r = XCBBigRequestsEnableReply(c, XCBBigRequestsEnable(c), 0);
-            c->out.maximum_request_length = r->maximum_request_length;
+            c->out.maximum_request_length_tag = LAZY_COOKIE;
+            c->out.maximum_request_length.cookie = xcb_big_requests_enable(c);
+        }
+        else
+        {
+            c->out.maximum_request_length_tag = LAZY_FORCED;
+            c->out.maximum_request_length.value = c->setup->maximum_request_length;
+        }
+    }
+    pthread_mutex_unlock(&c->out.reqlenlock);
+}
+
+uint32_t xcb_get_maximum_request_length(xcb_connection_t *c)
+{
+    if(c->has_error)
+        return 0;
+    xcb_prefetch_maximum_request_length(c);
+    pthread_mutex_lock(&c->out.reqlenlock);
+    if(c->out.maximum_request_length_tag == LAZY_COOKIE)
+    {
+        xcb_big_requests_enable_reply_t *r = xcb_big_requests_enable_reply(c, c->out.maximum_request_length.cookie, 0);
+        c->out.maximum_request_length_tag = LAZY_FORCED;
+        if(r)
+        {
+            c->out.maximum_request_length.value = r->maximum_request_length;
             free(r);
         }
+        else
+            c->out.maximum_request_length.value = c->setup->maximum_request_length;
     }
     pthread_mutex_unlock(&c->out.reqlenlock);
-    return c->out.maximum_request_length;
+    return c->out.maximum_request_length.value;
 }
 
-int XCBSendRequest(XCBConnection *c, unsigned int *request, int flags, struct iovec *vector, const XCBProtocolRequest *req)
+unsigned int xcb_send_request(xcb_connection_t *c, int flags, struct iovec *vector, const xcb_protocol_request_t *req)
 {
-    static const char pad[3];
-    int ret;
-    int i;
-    struct iovec *padded;
-    int padlen = 0;
-    CARD16 shortlen = 0;
-    CARD32 longlen = 0;
+    static const union {
+        struct {
+            uint8_t major;
+            uint8_t pad;
+            uint16_t len;
+        } fields;
+        uint32_t packet;
+    } sync_req = { { /* GetInputFocus */ 43, 0, 1 } };
+    unsigned int request;
+    uint32_t prefix[3] = { 0 };
+    int veclen = req->count;
     enum workarounds workaround = WORKAROUND_NONE;
 
+    if(c->has_error)
+        return 0;
+
     assert(c != 0);
-    assert(request != 0);
     assert(vector != 0);
     assert(req->count > 0);
 
-    /* set the major opcode, and the minor opcode for extensions */
-    if(req->ext)
+    if(!(flags & XCB_REQUEST_RAW))
     {
-        const XCBQueryExtensionRep *extension = XCBGetExtensionData(c, req->ext);
-        /* TODO: better error handling here, please! */
-        assert(extension && extension->present);
-        ((CARD8 *) vector[0].iov_base)[0] = extension->major_opcode;
-        ((CARD8 *) vector[0].iov_base)[1] = req->opcode;
+        static const char pad[3];
+        unsigned int i;
+        uint16_t shortlen = 0;
+        size_t longlen = 0;
+        assert(vector[0].iov_len >= 4);
+        /* set the major opcode, and the minor opcode for extensions */
+        if(req->ext)
+        {
+            const xcb_query_extension_reply_t *extension = xcb_get_extension_data(c, req->ext);
+            if(!(extension && extension->present))
+            {
+                _xcb_conn_shutdown(c);
+                return 0;
+            }
+            ((uint8_t *) vector[0].iov_base)[0] = extension->major_opcode;
+            ((uint8_t *) vector[0].iov_base)[1] = req->opcode;
+        }
+        else
+            ((uint8_t *) vector[0].iov_base)[0] = req->opcode;
 
-        /* do we need to work around the X server bug described in glx.xml? */
-        if(!req->isvoid && strcmp(req->ext->name, "GLX") &&
-                ((req->opcode == 17 && ((CARD32 *) vector[0].iov_base)[0] == 0x10004) ||
-                 req->opcode == 21))
-            workaround = WORKAROUND_GLX_GET_FB_CONFIGS_BUG;
-    }
-    else
-        ((CARD8 *) vector[0].iov_base)[0] = req->opcode;
+        /* put together the length field, possibly using BIGREQUESTS */
+        for(i = 0; i < req->count; ++i)
+        {
+            longlen += vector[i].iov_len;
+            if(!vector[i].iov_base)
+            {
+                vector[i].iov_base = (char *) pad;
+                assert(vector[i].iov_len <= sizeof(pad));
+            }
+        }
+        assert((longlen & 3) == 0);
+        longlen >>= 2;
 
-    /* put together the length field, possibly using BIGREQUESTS */
-    for(i = 0; i < req->count; ++i)
-        longlen += (vector[i].iov_len + 3) >> 2;
+        if(longlen <= c->setup->maximum_request_length)
+        {
+            /* we don't need BIGREQUESTS. */
+            shortlen = longlen;
+            longlen = 0;
+        }
+        else if(longlen > xcb_get_maximum_request_length(c))
+        {
+            _xcb_conn_shutdown(c);
+            return 0; /* server can't take this; maybe need BIGREQUESTS? */
+        }
 
-    if(longlen <= c->setup->maximum_request_length)
-    {
-        /* we don't need BIGREQUESTS. */
-        shortlen = longlen;
-        longlen = 0;
+        /* set the length field. */
+        ((uint16_t *) vector[0].iov_base)[1] = shortlen;
+        if(!shortlen)
+            prefix[2] = ++longlen;
     }
-    else if(longlen > XCBGetMaximumRequestLength(c))
-        return 0; /* server can't take this; maybe need BIGREQUESTS? */
+    flags &= ~XCB_REQUEST_RAW;
+
+    /* do we need to work around the X server bug described in glx.xml? */
+    /* XXX: GetFBConfigs won't use BIG-REQUESTS in any sane
+     * configuration, but that should be handled here anyway. */
+    if(req->ext && !req->isvoid && !strcmp(req->ext->name, "GLX") &&
+            ((req->opcode == 17 && ((uint32_t *) vector[0].iov_base)[1] == 0x10004) ||
+             req->opcode == 21))
+        workaround = WORKAROUND_GLX_GET_FB_CONFIGS_BUG;
 
-    padded =
-#ifdef HAVE_ALLOCA
-        alloca
-#else
-        malloc
-#endif
-        ((req->count * 2 + 3) * sizeof(struct iovec));
-    /* set the length field. */
-    ((CARD16 *) vector[0].iov_base)[1] = shortlen;
-    if(!shortlen)
+    /* get a sequence number and arrange for delivery. */
+    _xcb_lock_io(c);
+    /* wait for other writing threads to get out of my way. */
+    while(c->out.writing)
+        _xcb_wait_io(c, &c->out.cond);
+
+    request = ++c->out.request;
+    /* send GetInputFocus (sync_req) when 64k-2 requests have been sent without
+     * a reply.
+     * Also send sync_req (could use NoOp) at 32-bit wrap to avoid having
+     * applications see sequence 0 as that is used to indicate
+     * an error in sending the request */
+    while((req->isvoid &&
+	c->out.request == c->in.request_expected + (1 << 16) - 1) ||
+       request == 0)
     {
-        padded[0].iov_base = vector[0].iov_base;
-        padded[0].iov_len = sizeof(CARD32);
-        vector[0].iov_base = ((char *) vector[0].iov_base) + sizeof(CARD32);
-        vector[0].iov_len -= sizeof(CARD32);
-        ++longlen;
-        padded[1].iov_base = &longlen;
-        padded[1].iov_len = sizeof(CARD32);
-        padlen = 2;
+        prefix[0] = sync_req.packet;
+        _xcb_in_expect_reply(c, request, WORKAROUND_NONE, XCB_REQUEST_DISCARD_REPLY);
+        c->in.request_expected = c->out.request;
+	request = ++c->out.request;
     }
 
-    for(i = 0; i < req->count; ++i)
+    if(workaround != WORKAROUND_NONE || flags != 0)
+        _xcb_in_expect_reply(c, request, workaround, flags);
+    if(!req->isvoid)
+        c->in.request_expected = c->out.request;
+
+    if(prefix[0] || prefix[2])
     {
-        if(!vector[i].iov_len)
-            continue;
-        padded[padlen].iov_base = vector[i].iov_base;
-        padded[padlen++].iov_len = vector[i].iov_len;
-        if(!XCB_PAD(vector[i].iov_len))
-            continue;
-        padded[padlen].iov_base = (caddr_t) pad;
-        padded[padlen++].iov_len = XCB_PAD(vector[i].iov_len);
+        --vector, ++veclen;
+        if(prefix[2])
+        {
+            prefix[1] = ((uint32_t *) vector[1].iov_base)[0];
+            vector[1].iov_base = (uint32_t *) vector[1].iov_base + 1;
+            vector[1].iov_len -= sizeof(uint32_t);
+        }
+        vector[0].iov_len = sizeof(uint32_t) * (prefix[0] ? 1 : 0 | prefix[2] ? 2 : 0);
+        vector[0].iov_base = prefix + !prefix[0];
     }
 
-    /* get a sequence number and arrange for delivery. */
-    pthread_mutex_lock(&c->iolock);
-    if(req->isvoid && !force_sequence_wrap(c))
+    if(!write_block(c, vector, veclen))
     {
-        pthread_mutex_unlock(&c->iolock);
-#ifndef HAVE_ALLOCA
-        free(padded);
-#endif
-        return -1;
+        _xcb_conn_shutdown(c);
+        request = 0;
     }
-
-    *request = ++c->out.request;
-
-    _xcb_in_expect_reply(c, *request, workaround, flags);
-
-    ret = _xcb_out_write_block(c, padded, padlen);
-    pthread_mutex_unlock(&c->iolock);
-#ifndef HAVE_ALLOCA
-    free(padded);
-#endif
-
-    return ret;
+    _xcb_unlock_io(c);
+    return request;
 }
 
-int XCBFlush(XCBConnection *c)
+int xcb_flush(xcb_connection_t *c)
 {
     int ret;
-    pthread_mutex_lock(&c->iolock);
-    ret = _xcb_out_flush(c);
-    pthread_mutex_unlock(&c->iolock);
+    if(c->has_error)
+        return 0;
+    _xcb_lock_io(c);
+    ret = _xcb_out_flush_to(c, c->out.request);
+    _xcb_unlock_io(c);
     return ret;
 }
 
@@ -201,15 +255,13 @@ int _xcb_out_init(_xcb_out *out)
     out->writing = 0;
 
     out->queue_len = 0;
-    out->vec = 0;
-    out->vec_len = 0;
 
     out->request = 0;
     out->request_written = 0;
 
     if(pthread_mutex_init(&out->reqlenlock, 0))
         return 0;
-    out->maximum_request_length = 0;
+    out->maximum_request_length_tag = LAZY_NONE;
 
     return 1;
 }
@@ -220,74 +272,32 @@ void _xcb_out_destroy(_xcb_out *out)
     pthread_mutex_destroy(&out->reqlenlock);
 }
 
-/* precondition: there must be something for us to write. */
-int _xcb_out_write(XCBConnection *c)
+int _xcb_out_send(xcb_connection_t *c, struct iovec **vector, int *count)
 {
-    int n;
-    assert(!c->out.queue_len);
-    n = writev(c->fd, c->out.vec, c->out.vec_len);
-    if(n < 0 && errno == EAGAIN)
-        return 1;
-    if(n <= 0)
-        return 0;
-
-    for(; c->out.vec_len; --c->out.vec_len, ++c->out.vec)
-    {
-        int cur = c->out.vec->iov_len;
-        if(cur > n)
-            cur = n;
-        c->out.vec->iov_len -= cur;
-        c->out.vec->iov_base = (char *) c->out.vec->iov_base + cur;
-        n -= cur;
-        if(c->out.vec->iov_len)
-            break;
-    }
-    if(!c->out.vec_len)
-        c->out.vec = 0;
-    assert(n == 0);
-    return 1;
+    int ret = 1;
+    while(ret && *count)
+        ret = _xcb_conn_wait(c, &c->out.cond, vector, count);
+    c->out.request_written = c->out.request;
+    pthread_cond_broadcast(&c->out.cond);
+    return ret;
 }
 
-int _xcb_out_write_block(XCBConnection *c, struct iovec *vector, size_t count)
+int _xcb_out_flush_to(xcb_connection_t *c, unsigned int request)
 {
-    while(c->out.writing)
-        pthread_cond_wait(&c->out.cond, &c->iolock);
-    assert(!c->out.vec && !c->out.vec_len);
-    while(count && c->out.queue_len + vector[0].iov_len < sizeof(c->out.queue))
-    {
-        memcpy(c->out.queue + c->out.queue_len, vector[0].iov_base, vector[0].iov_len);
-        c->out.queue_len += vector[0].iov_len;
-        ++vector, --count;
-    }
-    if(!count)
+    assert(XCB_SEQUENCE_COMPARE(request, <=, c->out.request));
+    if(XCB_SEQUENCE_COMPARE(c->out.request_written, >=, request))
         return 1;
-
-    memmove(vector + 1, vector, count++ * sizeof(struct iovec));
-    vector[0].iov_base = c->out.queue;
-    vector[0].iov_len = c->out.queue_len;
-    c->out.queue_len = 0;
-
-    c->out.vec_len = count;
-    c->out.vec = vector;
-    return _xcb_out_flush(c);
-}
-
-int _xcb_out_flush(XCBConnection *c)
-{
-    int ret = 1;
-    struct iovec vec;
     if(c->out.queue_len)
     {
-        assert(!c->out.vec && !c->out.vec_len);
+        struct iovec vec, *vec_ptr = &vec;
+        int count = 1;
         vec.iov_base = c->out.queue;
         vec.iov_len = c->out.queue_len;
-        c->out.vec = &vec;
-        c->out.vec_len = 1;
         c->out.queue_len = 0;
+        return _xcb_out_send(c, &vec_ptr, &count);
     }
-    while(ret && c->out.vec_len)
-        ret = _xcb_conn_wait(c, /*should_write*/ 1, &c->out.cond);
-    c->out.request_written = c->out.request;
-    pthread_cond_broadcast(&c->out.cond);
-    return ret;
+    while(c->out.writing)
+        _xcb_wait_io(c, &c->out.cond);
+    assert(XCB_SEQUENCE_COMPARE(c->out.request_written, >=, request));
+    return 1;
 }