X-Git-Url: http://git.demorecorder.com/cgi-bin/gitweb.cgi?a=blobdiff_plain;f=src%2Fxcb_conn.c;h=827a12be70f4fbdbf331abeffd98e2176e79c93a;hb=4d828c5eba9fc7161c5f18650f2dbe218e1db06f;hp=9aa7cdf14570be89f87ee173e0b28989bf68401b;hpb=a3bd6f4760b5b3f5f360a690920839646e2b9d06;p=free-sw%2Fxcb%2Flibxcb diff --git a/src/xcb_conn.c b/src/xcb_conn.c index 9aa7cdf..827a12b 100644 --- a/src/xcb_conn.c +++ b/src/xcb_conn.c @@ -48,7 +48,7 @@ static const int error_connection = 1; static int set_fd_flags(const int fd) { - long flags = fcntl(fd, F_GETFL, 0); + int flags = fcntl(fd, F_GETFL, 0); if(flags == -1) return 0; flags |= O_NONBLOCK; @@ -59,6 +59,21 @@ static int set_fd_flags(const int fd) return 1; } +static int _xcb_xlib_init(_xcb_xlib *xlib) +{ + xlib->lock = 0; +#ifndef NDEBUG + xlib->sloppy_lock = (getenv("LIBXCB_ALLOW_SLOPPY_LOCK") != 0); +#endif + pthread_cond_init(&xlib->cond, 0); + return 1; +} + +static void _xcb_xlib_destroy(_xcb_xlib *xlib) +{ + pthread_cond_destroy(&xlib->cond); +} + static int write_setup(xcb_connection_t *c, xcb_auth_info_t *auth_info) { static const char pad[3]; @@ -97,12 +112,12 @@ static int write_setup(xcb_connection_t *c, xcb_auth_info_t *auth_info) } assert(count <= sizeof(parts) / sizeof(*parts)); - pthread_mutex_lock(&c->iolock); + _xcb_lock_io(c); { struct iovec *parts_ptr = parts; ret = _xcb_out_send(c, &parts_ptr, &count); } - pthread_mutex_unlock(&c->iolock); + _xcb_unlock_io(c); return ret; } @@ -215,6 +230,7 @@ xcb_connection_t *xcb_connect_to_fd(int fd, xcb_auth_info_t *auth_info) if(!( set_fd_flags(fd) && pthread_mutex_init(&c->iolock, 0) == 0 && + _xcb_xlib_init(&c->xlib) && _xcb_in_init(&c->in) && _xcb_out_init(&c->out) && write_setup(c, auth_info) && @@ -239,6 +255,7 @@ void xcb_disconnect(xcb_connection_t *c) close(c->fd); pthread_mutex_destroy(&c->iolock); + _xcb_xlib_destroy(&c->xlib); _xcb_in_destroy(&c->in); _xcb_out_destroy(&c->out); @@ -255,6 +272,22 @@ void _xcb_conn_shutdown(xcb_connection_t *c) c->has_error = 1; } +void _xcb_lock_io(xcb_connection_t *c) +{ + pthread_mutex_lock(&c->iolock); + while(c->xlib.lock) + { + if(pthread_equal(c->xlib.thread, pthread_self())) + break; + pthread_cond_wait(&c->xlib.cond, &c->iolock); + } +} + +void _xcb_unlock_io(xcb_connection_t *c) +{ + pthread_mutex_unlock(&c->iolock); +} + int _xcb_conn_wait(xcb_connection_t *c, pthread_cond_t *cond, struct iovec **vector, int *count) { int ret; @@ -278,7 +311,7 @@ int _xcb_conn_wait(xcb_connection_t *c, pthread_cond_t *cond, struct iovec **vec ++c->out.writing; } - pthread_mutex_unlock(&c->iolock); + _xcb_unlock_io(c); do { ret = select(c->fd + 1, &rfds, &wfds, 0, 0); } while (ret == -1 && errno == EINTR); @@ -287,7 +320,7 @@ int _xcb_conn_wait(xcb_connection_t *c, pthread_cond_t *cond, struct iovec **vec _xcb_conn_shutdown(c); ret = 0; } - pthread_mutex_lock(&c->iolock); + _xcb_lock_io(c); if(ret) {